From 8d4e0429e4a376a36348e018f9c80c06279d965d Mon Sep 17 00:00:00 2001 From: Philippe-Cholet <44676486+Philippe-Cholet@users.noreply.github.com> Date: Wed, 7 Feb 2024 14:01:25 +0100 Subject: [PATCH] Do not mention specializing `collect` In libcore, no adaptor specialize `collect` so I'm not sure why we should. --- CONTRIBUTING.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a3a85f54f..0583b46b9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -58,8 +58,6 @@ Most of the time, we want specializations of: Additionally, -- [`collect`](https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.collect) - might make collection faster than calling `next` repeatedly. - `for_each`, `reduce`, `max/min[_by[_key]]` and `partition` all rely on `fold` so you should specialize it instead. - `all`, `any`, `find`, `find_map`, `cmp`, `partial_cmp`, `eq`, `ne`, `lt`, `le`, `gt`, `ge` and `position` all rely (by default) on `try_fold` which we can not specialize on stable rust, so you might want to wait it stabilizes