Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2CRegisterMap panics when reading with offset 0 #84

Open
Disasm opened this issue Feb 25, 2024 · 0 comments
Open

I2CRegisterMap panics when reading with offset 0 #84

Disasm opened this issue Feb 25, 2024 · 0 comments

Comments

@Disasm
Copy link
Member

Disasm commented Feb 25, 2024

#[test]
fn check_read_0() {
    let mut i2c = MockI2CDevice::new();
    let value = i2c.smbus_read_byte_data(0).unwrap();
    assert_eq!(value, 0);
}

This code panics with attempt to subtract with overflow because offset is no longer incremented inside I2CRegisterMap::read after 6671e87. Probably it should be incremented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant