Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smbus Unimplemented in MockI2CDevice #63

Open
WugWugg opened this issue May 27, 2020 · 1 comment
Open

Smbus Unimplemented in MockI2CDevice #63

WugWugg opened this issue May 27, 2020 · 1 comment

Comments

@WugWugg
Copy link

WugWugg commented May 27, 2020

I found that the smbus functions were unimplemented when trying to test my code. I require access to these functions because I use the smbus_* in the driver to communicate to the peripheral. I'm suggesting just having the smbus_* methods do a the appropriate mapping to the already implemented MockI2CDevice's read() and write() methods.

Is there a reason the MockI2CDevice's smbus_* methods weren't implemented? Is it as simple as calling MockI2CDevice's read/write methods or am I missing something larger?

@posborne
Copy link
Member

@DarkWugWug Probably just an oversight; feel free to open a PR to fill in that functionality on the mock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants