Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpiu: bitfield ACPR, verify set_swo_baud_rate args and ops #389

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmplt
Copy link
Contributor

@tmplt tmplt commented Jan 10, 2022

Draft improvement that closes #388.

At this point we might as well implement a TPIU::configure akin to {DWT,ITM}::configure. Other register functions will have to be reviewed to see if any other errors can be caught. We should also check swo_supports to see if a non-zero prescaler is supported at all.

@rust-highfive
Copy link

r? @thalesfragoso

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TPIU: set_swo_baud_rate silently integer divisions, does not verify prescaler
3 participants