-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extreme negative elevation values in some run coordinates #141
Comments
Side question: how stable are run and slope IDs across time? What goes into their derivation? |
I think that can happen because there are voids in the SRTM elevation dataset. Probably ideally we'd use a dataset which doesn't have these issues or just remove the elevation data entirely for a feature when invalid data is detected.
I think the id's are determined by a hash of feature geometry + feature type. They are not super stable. |
Ah good to know. I see on the SRTM data page that there are three data sets:
From this description it's not entirely clear to me whether any of these datasets entirely avoid voids.
I'm -1 to removing elevation for the entire feature, since in the screenshots above only a single elevation value is bad for the entire run. Not sure if the geojson and infra supports single element null values? Thanks for the feature hashing link. |
You are right, it makes more sense just to exclude elevation for specific points. It might also require adaptation on the frontend to account for that. Given this appears to affect a very small fraction of the overall dataset affected, I probably won't work on this soon. |
Not a problem. Nullifying elevations < -100 meters solved the issue for my application, so the fix was easy once I was aware of the issue. |
The following downhill runs have coordinates with extreme negative elevations (100 meters below sea level or more) in data downloaded on 2024-10-13.
Going to these now, the issue only shows up on the frontend for some the runs. For example, this run is currently exhibiting the issue:
Another run with the issue currently is Hslcón Peregrino of Cerro Castor in Argentina, although this issue did not exist in the download.
The text was updated successfully, but these errors were encountered: