Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD email in CODE_OF_CONDUCT.md #2332

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

JuanPabloDiaz
Copy link
Contributor

Fixes Issue

fixes #2325

Changes proposed

The Code of conduct now has @rupali-codes email: [email protected]

Screenshots

Note to reviewers

Copy link

vercel bot commented Mar 29, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, JuanPabloDiaz, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @rupali-codes or @aftabrehan, it's your turn

aftabrehan
aftabrehan previously approved these changes Apr 1, 2024
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2024 1:45pm

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please replace the email with [email protected]

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JuanPabloDiaz. It turns out the email you put is incorrect. Please fix and tag me and @rupali-codes for another review

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @JuanPabloDiaz! :) In the future, click on the “Commit” button when you see an embedded suggestion in your pull requests.

@CBID2 CBID2 requested review from rupali-codes and aftabrehan April 5, 2024 01:18
@CBID2 CBID2 added bug Something isn't working documentation Improvements or additions to documentation labels Apr 5, 2024
@rupali-codes rupali-codes merged commit d2d7479 into rupali-codes:main Apr 6, 2024
7 checks passed
@JuanPabloDiaz JuanPabloDiaz deleted the email branch May 30, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing email in CODE_OF_CONDUCT.md
4 participants