From 3900a8f8db83fde6fc19007a1aac6a4c022567fa Mon Sep 17 00:00:00 2001 From: Freeman <105403280+F-WRunTime@users.noreply.github.com> Date: Thu, 19 Sep 2024 14:19:15 -0600 Subject: [PATCH] Continue on failure to pull / push from kaas caches (#11) * Removing the tag latest and moving to a tag system based on the version of the file containing the test set being run i.e. run_kontrol.sh If a download from the cache server fails this should not fail the test overall. It will just take longer. modified: .github/workflows/optimism-ci.yaml * If uploading the latest cache fails it does not mean the test itself failed. Do not stop or fail a test because this upload step failed. --- .github/workflows/optimism-ci.yaml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/optimism-ci.yaml b/.github/workflows/optimism-ci.yaml index a1a31a2..8145a7f 100644 --- a/.github/workflows/optimism-ci.yaml +++ b/.github/workflows/optimism-ci.yaml @@ -25,7 +25,7 @@ on: # Multiple Runs will need to be allowed to queue concurrency: group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.inputs.statuses_sha }} - cancel-in-progress: true + cancel-in-progress: false jobs: optimism: @@ -106,9 +106,11 @@ jobs: - name: "Download KCFG Cache Results" shell: bash + continue-on-error: true run: | pushd optimism/packages/contracts-bedrock > /dev/null - kaas-cli download --token ${{ secrets.OPTIMISM_TOKEN }} runtimeverification/optimism-ci:latest -d ./kout-proofs/ + tag=$(git hash-object ./test/kontrol/scripts/run-kontrol.sh) + kaas-cli download --token "${{ secrets.OPTIMISM_TOKEN }}" "runtimeverification/optimism-ci:$tag" -d ./kout-proofs/ - name: 'Run Kontrol' shell: bash @@ -123,10 +125,11 @@ jobs: - name: 'KCFG Upload Cache Results' shell: bash if: always() + continue-on-error: true run: | pushd optimism/packages/contracts-bedrock > /dev/null - kaas-cli upload --token ${{ secrets.OPTIMISM_TOKEN }} runtimeverification/optimism-ci:${{ github.event.inputs.statuses_sha }} -d ./kout-proofs/ - kaas-cli upload --token ${{ secrets.OPTIMISM_TOKEN }} runtimeverification/optimism-ci:latest -d ./kout-proofs/ + tag=$(git hash-object ./test/kontrol/scripts/run-kontrol.sh) + kaas-cli upload --token "${{ secrets.OPTIMISM_TOKEN }}" "runtimeverification/optimism-ci:$tag" -d ./kout-proofs/ - name: 'Upload KCFG Results to Summary' if: always()