Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Scala auto-formatter #3827

Closed
Scott-Guest opened this issue Nov 24, 2023 · 2 comments
Closed

Adopt Scala auto-formatter #3827

Scott-Guest opened this issue Nov 24, 2023 · 2 comments
Assignees
@Scott-Guest

Comments

@Scott-Guest
Copy link
Contributor

Scott-Guest commented Nov 24, 2023 •
edited
Loading

Similarly to #3757, we should consider adopting a Scala auto-formatter.

scalafmt seems to be a popular choice and is easily integrated with IntelliJ. The default settings look fine for me, perhaps setting maxColumn = 100 to align with the Java formatter.
@Baltoli
Copy link
Contributor

Baltoli commented Nov 28, 2023

@radumereuta queries whether there are any semantic aspects to the formatting introduced here, or if it's purely stylistic. It might also be worth taking a look at what we get from IntelliJ. Any low-hanging fixes are probably worth doing.

@Baltoli
Copy link
Contributor

Baltoli commented Nov 28, 2023

@Scott-Guest suggests that it might also be worth looking at what bits of Scala we could port to Java?

@Scott-Guest Scott-Guest self-assigned this Nov 29, 2023
@Scott-Guest Scott-Guest mentioned this issue Dec 5, 2023
Merged
@Baltoli Baltoli mentioned this issue Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scott-Guest Scott-Guest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Baltoli @Scott-Guest