Skip to content

Latest commit

 

History

History
138 lines (89 loc) · 8.8 KB

README.md

File metadata and controls

138 lines (89 loc) · 8.8 KB
Raw

ABOUT THIS FORK

This fork is removing all dependencies for elasticsearch and opensearch.
It removes elasticsearch, elasticsearch7 and opensearch modules from the codebase.
As a replacement the module swissup/module-search-mysql-legacy is added, which contains an adapted version of the latest mysql search implementation from Magento 2.3.7.

In addition to that, all references and usages of elasticsearch are removed in this fork.

Main Changes

  • include swissup/module-search-mysql-legacy
  • remove modules
    • magento/module-elasticsearch
    • magento/module-elasticsearch7
    • magento/module-opensearch
    • elasticsearch/elasticsearch from root composer.json
  • cleanup SearchConfigOptionsList so options are removed from CLI setup:install
  • dev/tests modifications

Tests

The fork has been tested with the mage-os / sample-data, both during install and setup:upgrade.

There is one Test that has a hard requirement for an elasticsearch class: app/code/Magento/CatalogSearch/Test/Unit/Model/Indexer/FulltextTest.php

There is other places where elasticsearch is used for naming:

  • Mftf Tests (are being used?)
  • Integration Tests
  • api-functional
  • phpcpd

References to elasticsearch which are deemed relevant have not (yet) been removed.

Notes

Test dev/tests/integration/testsuite/Magento/Catalog/Model/Layer/Filter/Price/AlgorithmBaseTest.php has some references to elasticsearch but seems to also have other missing dependencies.

setup/src/Magento/Setup/Model/SearchConfigOptionsList.php should be made configurable to get available search-engines, using di.xml fromn the modules that are installed.
Module magento/module-elasticsearch should contain the options to select elasticsearch during install process.
For now the options in \Magento\Setup\Model\SearchConfigOptionsList::getAvailableSearchEngineList have been disabled.

\Magento\Setup\Model\SearchConfigOptionsList::getOptionsList also needs to be made extensible by di.

NEXT STEPS

  • Execute Test Suites and see if affected Tests work
  • Make SearchConfigOptionsList configurable through di
  • Configure SearchConfigOptionsList for elasticsearch 7/8 and opensearch modules

Open Source Helpers Gitter Crowdin
Adobe logo

Magento Open Source

Welcome to the Magento Open Source project! Magento Open Source software delivers basic eCommerce capabilities to build a unique online store from the ground up.

However, for those who need a full-featured eCommerce solution, we recommend Adobe Commerce, which includes our optimized cloud architecture and hosting as well as AI-powered merchandising and analytics.

Get started

Get help

Contribute

Our Community is large and diverse, and our project is enormous. As a contributor, you have countless opportunities to impact product development and delivery by introducing new features or improving existing ones, enhancing test coverage, updating documentation for developers and end-users, catching and fixing code bugs, suggesting points for optimization, and sharing your great ideas.

Maintainers

We encourage experts from the Community to help us with GitHub routines such as accepting, merging, or rejecting pull requests and reviewing issues. Adobe has granted the Community Maintainers permission to accept, merge, and reject pull requests, as well as review issues. Thanks to invaluable input from the Community Maintainers team, we can significantly improve contribution quality and accelerate the time to deliver your updates to production.

Leaders

Adobe highly appreciates contributions that help us to improve the code, clarify the documentation, and increase test coverage. Check out our Community leaders, superstars, and superheroes on the leaderboard.

Labeling

We use labels in the GitHub issues and pull requests to help the participants retrieve additional information such as progress, component assignments, or release lines.

Security

Security is one of the highest priorities at Adobe. To learn more about reporting security concerns, visit the Adobe Bug Bounty Program.

Stay up-to-date on the latest security news and patches by signing up for Security Alert Notifications.

Licensing

Each Magento source file included in this distribution is licensed under OSL 3.0 or the terms and conditions of the applicable ordering document between Licensee/Customer and Adobe (or Magento).

Open Software License (OSL 3.0) – Please see LICENSE.txt for the full text of the OSL 3.0 license.

Subject to Licensee's/Customer's payment of fees and compliance with the terms and conditions of the applicable ordering document between Licensee/Customer and Adobe (or Magento), the terms and conditions of the applicable ordering between Licensee/Customer and Adobe (or Magento) supersede the OSL 3.0 license for each source file.

Communications

We are dedicated to our Community and encourage your contributions and welcome feedback through events, our DevBlog, Twitter and YouTube channels, and other Community resources.

To connect with people from the Community and Adobe engineering, join us in Slack. We have a channel for every project. To join a particular channel, send us a request at [email protected], or sign up.

If you are a new Community member, check out the following channels:

  • general is an open chat for introductions and Magento 2 questions
  • github is a support channel for GitHub issues, pull requests, and processes
  • public-backlog for discussions of the backlog