avm2: Use direct slot access in more native code #18911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
force-pushed
the
avm2-primobj-3
branch
2 times, most recently
from
0e2b0b0 to
9c763d1
Compare
Lord-McSweeney
added
A-avm2
Lord-McSweeney
force-pushed
the
avm2-primobj-3
branch
3 times, most recently
from
9513d17 to
cd21130
Compare
adrian17
reviewed
Dec 10, 2024
adrian17
reviewed
Dec 10, 2024
adrian17
reviewed
Dec 10, 2024
adrian17
reviewed
Dec 10, 2024
adrian17
reviewed
Dec 10, 2024
Lord-McSweeney
force-pushed
the
avm2-primobj-3
branch
from
69bd560 to
296e6d5
Compare
adrian17
approved these changes
Dec 13, 2024
added 15 commits
December 13, 2024 22:03
This removes `FunctionObject::from_function`, replacing it with `FunctionObject::from_method` which also now always allocates a prototype. Also, `Object::is_instance_of` has been simplified and moved to `Value`.
… some Shader classes
…` in `Metadata::as_json_object`
added 20 commits
December 13, 2024 22:03
…ndent` in E4X code
…ct Objects instead of usual construction pipeline
torokati44
force-pushed
the
avm2-primobj-3
branch
from
296e6d5 to
269afce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a bug with
BitmapData.paletteMapnot using the right coordinates for the destination point, and another bug withPressAndTapGestureEvent::tapStageX/Ynot working at all.Notable changes:
Object::is_instance_ofhas been replaced with the new methodValue::is_instance_ofFunctionObject::from_functionhave been replaced withFunctionObject::from_method. Previously, the former allocated a prototype while the latter did not; now,from_methodalways allocates a prototype.