Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding proxy test cases for salesforce oauth #3170

Merged
merged 14 commits into from
Mar 12, 2024
Merged

chore: adding proxy test cases for salesforce oauth #3170

merged 14 commits into from
Mar 12, 2024

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Mar 6, 2024 •
edited
Loading

What are the changes introduced in this PR?

We have already added test cases for Salesforce. As Salesforce Oauth uses the same code base, except network handler ( in case of invalid session id ) we are adding a test case for the refresh token scenario.
For this oauth flow of the destination no test cases were added previously.

As no test cases were added previously in this flow. So new number of test cases: 2
Vulnerabilities caught : 0

What is the related Linear task?

Resolves INT-1493

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review

Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 self-assigned this Mar 6, 2024
@shrouti1507 shrouti1507 requested review from sivashanmukh and a team as code owners March 6, 2024 14:04
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@shrouti1507 shrouti1507 changed the title Salesforce oauth proxy v1 chore: adding proxy test cases for salesforce oauth Mar 6, 2024
@devops-github-rudderstack
Copy link
Contributor

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3170/test-report.html

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (c1b3736) to head (fb2bff1).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3170      +/-   ##
===========================================
+ Coverage    84.86%   84.89%   +0.03%     
===========================================
  Files          497      497              
  Lines        27412    27412              
  Branches      6597     6599       +2     
===========================================
+ Hits         23262    23271       +9     
+ Misses        3723     3685      -38     
- Partials       427      456      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrouti1507 @yashasvibajpai
code review suggestion
90446d8 
Co-authored-by: Yashasvi Bajpai <[email protected]>
@yashasvibajpai
Copy link
Member

@shrouti1507 seeing lint related test failing, can you check it?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@shrouti1507 shrouti1507 requested a review from utsabc March 11, 2024 14:34
@shrouti1507 shrouti1507 merged commit 5dd5142 into develop Mar 12, 2024
19 checks passed
@shrouti1507 shrouti1507 deleted the salesforce-oauth-proxy-v1 branch March 12, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashasvibajpai yashasvibajpai yashasvibajpai approved these changes

@utsabc utsabc utsabc approved these changes

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

Assignees

@shrouti1507 shrouti1507

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shrouti1507 @devops-github-rudderstack @yashasvibajpai @utsabc