From ae18c9a23a3d84e8199be0db2a1cda1b285510fe Mon Sep 17 00:00:00 2001
From: Aanshi Lahoti <aanshilahoti677@gmail.com>
Date: Mon, 9 Dec 2024 10:54:01 +0530
Subject: [PATCH] chore: function updates

---
 src/v0/destinations/topsort/transform.js | 45 +++++++++++++-----------
 1 file changed, 24 insertions(+), 21 deletions(-)

diff --git a/src/v0/destinations/topsort/transform.js b/src/v0/destinations/topsort/transform.js
index 48eedbe900..6b72b9fdd2 100644
--- a/src/v0/destinations/topsort/transform.js
+++ b/src/v0/destinations/topsort/transform.js
@@ -14,14 +14,14 @@ const {
 } = require('./utils');
 
 // Function to process events with a product array
-const processProductArray = (
+const processProductArray = ({
   products,
   basePayload,
   placementPayload,
   topsortEvent,
   apiKey,
   finalPayloads,
-) => {
+}) => {
   const itemPayloads = constructItemPayloads(products, mappingConfig[ConfigCategory.ITEM.name]);
   itemPayloads.forEach((itemPayload) => {
     const eventData = createEventData(basePayload, placementPayload, itemPayload, topsortEvent);
@@ -30,7 +30,7 @@ const processProductArray = (
 };
 
 // Function to process events with a single product or no product data
-const processSingleProduct = (
+const processSingleProduct = ({
   basePayload,
   placementPayload,
   message,
@@ -38,7 +38,7 @@ const processSingleProduct = (
   apiKey,
   finalPayloads,
   messageId,
-) => {
+}) => {
   const itemPayload = constructPayload(message, mappingConfig[ConfigCategory.ITEM.name]);
   const eventData = createEventData(basePayload, placementPayload, itemPayload, topsortEvent);
 
@@ -61,37 +61,40 @@ const responseBuilder = (message, { Config }) => {
     throw new InstrumentationError("Event not mapped in 'topsortEvents'. Dropping the event.");
   }
 
-  const topsortEvent = mappedEventName;
+  const topsortEventName = mappedEventName;
 
   // Construct base and placement payloads
   const basePayload = constructPayload(message, mappingConfig[ConfigCategory.TRACK.name]);
   const placementPayload = constructPayload(message, mappingConfig[ConfigCategory.PLACEMENT.name]);
 
+  // Destructure products from properties (if available)
+  const { products, messageId } = properties;
+
   // Check if the event involves a product array (using ECOMM_EVENTS_WITH_PRODUCT_ARRAY)
   const isProductArrayAvailable =
     ECOMM_EVENTS_WITH_PRODUCT_ARRAY.includes(event) && isProductArrayValid(event, properties);
 
   const finalPayloads = [];
 
-  // Handle events based on the presence of a product array
+  const commonArgs = {
+    basePayload,
+    placementPayload,
+    topsortEventName,
+    apiKey,
+    finalPayloads,
+  };
+
   if (isProductArrayAvailable) {
-    processProductArray(
-      properties.products,
-      basePayload,
-      placementPayload,
-      topsortEvent,
-      apiKey,
-      finalPayloads,
-    );
+    processProductArray({
+      ...commonArgs,
+      products, // Directly use destructured products
+    });
   } else {
-    processSingleProduct(
-      basePayload,
-      placementPayload,
+    processSingleProduct({
+      ...commonArgs,
       message,
-      topsortEvent,
-      apiKey,
-      finalPayloads,
-    );
+      messageId, // Add 'messageId' for single product event
+    });
   }
 
   return finalPayloads;