diff --git a/src/v0/destinations/google_adwords_enhanced_conversions/data/trackConfig.json b/src/v0/destinations/google_adwords_enhanced_conversions/data/trackConfig.json index d98b71eb5d..562a77f0e8 100644 --- a/src/v0/destinations/google_adwords_enhanced_conversions/data/trackConfig.json +++ b/src/v0/destinations/google_adwords_enhanced_conversions/data/trackConfig.json @@ -129,13 +129,5 @@ "metadata": { "type": "hashToSha256" } - }, - { - "destKey": "jobId", - "sourceKeys": ["properties.jobId"], - "required": false, - "metadata": { - "type": "toInt" - } } ] diff --git a/src/v0/destinations/google_adwords_enhanced_conversions/transform.js b/src/v0/destinations/google_adwords_enhanced_conversions/transform.js index 0be7c3f0ee..cf5bf8afa8 100644 --- a/src/v0/destinations/google_adwords_enhanced_conversions/transform.js +++ b/src/v0/destinations/google_adwords_enhanced_conversions/transform.js @@ -77,6 +77,8 @@ const processTrackEvent = async (metadata, message, destination) => { const payload = constructPayload(message, updatedMapping); payload.partialFailure = true; + // ref: https://developers.google.com/google-ads/api/docs/release-notes#:~:text=Added%20job_id%20as,UploadConversionAdjustmentsRequest + payload.jobId = metadata.jobId; if (!payload.conversionAdjustments[0]?.userIdentifiers) { throw new InstrumentationError( `Any of email, phone, firstName, lastName, city, street, countryCode, postalCode or streetAddress is required in traits.`, diff --git a/test/integrations/destinations/google_adwords_enhanced_conversions/processor/data.ts b/test/integrations/destinations/google_adwords_enhanced_conversions/processor/data.ts index 1032b3b13c..ba6aa5f1e4 100644 --- a/test/integrations/destinations/google_adwords_enhanced_conversions/processor/data.ts +++ b/test/integrations/destinations/google_adwords_enhanced_conversions/processor/data.ts @@ -1566,7 +1566,6 @@ export const data = [ adjustmentType: 'ENHANCEMENT', }, ], - jobId: 1, partialFailure: true, }, JSON_ARRAY: {}, diff --git a/test/integrations/destinations/google_adwords_enhanced_conversions/router/data.ts b/test/integrations/destinations/google_adwords_enhanced_conversions/router/data.ts index 4153630323..68ed5454cf 100644 --- a/test/integrations/destinations/google_adwords_enhanced_conversions/router/data.ts +++ b/test/integrations/destinations/google_adwords_enhanced_conversions/router/data.ts @@ -304,6 +304,7 @@ export const data = [ params: { event: 'Page View', customerId: '1234567890' }, body: { JSON: { + jobId: 1, partialFailure: true, conversionAdjustments: [ {