From 860a9bb6e6e5d7aceacb83c6a0b7792e88705a71 Mon Sep 17 00:00:00 2001 From: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Date: Fri, 20 Sep 2024 10:44:07 +0530 Subject: [PATCH 1/3] fix: set wunderkind accountId and instanceId as secret in ui (#1697) --- src/configurations/destinations/wunderkind/ui-config.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/configurations/destinations/wunderkind/ui-config.json b/src/configurations/destinations/wunderkind/ui-config.json index a7702be77..05ceece29 100644 --- a/src/configurations/destinations/wunderkind/ui-config.json +++ b/src/configurations/destinations/wunderkind/ui-config.json @@ -18,7 +18,8 @@ "configKey": "accountID", "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$", "regexErrorMessage": "Invalid Account ID", - "placeholder": "e.g. 599xx" + "placeholder": "e.g. 599xx", + "secret": true }, { "type": "textInput", @@ -27,7 +28,8 @@ "configKey": "instanceID", "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$", "regexErrorMessage": "Invalid Instance ID", - "placeholder": "e.g. wr4xxx85m-1" + "placeholder": "e.g. wr4xxx85m-1", + "secret": true }, { "type": "textInput", From 3583ce8dcefead90ba10b7750bd5333e89dc41c3 Mon Sep 17 00:00:00 2001 From: Akash Chetty Date: Fri, 20 Sep 2024 11:42:55 +0530 Subject: [PATCH 2/3] fix: kafka topic name regex (#1698) --- src/configurations/destinations/kafka/ui-config.json | 2 +- test/data/validation/destinations/kafka.json | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/configurations/destinations/kafka/ui-config.json b/src/configurations/destinations/kafka/ui-config.json index eaaf8b8c6..b5225ebe4 100644 --- a/src/configurations/destinations/kafka/ui-config.json +++ b/src/configurations/destinations/kafka/ui-config.json @@ -35,7 +35,7 @@ "label": "Topic Name", "note": "Please enter the topic name", "configKey": "topic", - "regex": "^[a-zA-Z0-9_\\-]{1,249}$", + "regex": "^[a-zA-Z0-9_.\\-]{1,249}$", "regexErrorMessage": "Invalid Topic Name", "placeholder": "e.g: test-topic" } diff --git a/test/data/validation/destinations/kafka.json b/test/data/validation/destinations/kafka.json index 71059ab06..3bb4064a3 100644 --- a/test/data/validation/destinations/kafka.json +++ b/test/data/validation/destinations/kafka.json @@ -31,6 +31,14 @@ }, "result": true }, + { + "config": { + "hostName": "rudder.com", + "port": "65535", + "topic": "test.Topic-1_2_3" + }, + "result": true + }, { "config": { "hostName": "rudder.com", From fae27a09e3f2c590aa1350cb003d541d387cc86e Mon Sep 17 00:00:00 2001 From: GitHub Actions Date: Fri, 20 Sep 2024 06:18:22 +0000 Subject: [PATCH 3/3] chore(release): 1.92.1 --- CHANGELOG.md | 8 ++++++++ package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 330764c02..faaa38436 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,14 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### [1.92.1](https://github.com/rudderlabs/rudder-config-schema/compare/v1.92.0...v1.92.1) (2024-09-20) + + +### Bug Fixes + +* kafka topic name regex ([#1698](https://github.com/rudderlabs/rudder-config-schema/issues/1698)) ([3583ce8](https://github.com/rudderlabs/rudder-config-schema/commit/3583ce8dcefead90ba10b7750bd5333e89dc41c3)) +* set wunderkind accountId and instanceId as secret in ui ([#1697](https://github.com/rudderlabs/rudder-config-schema/issues/1697)) ([860a9bb](https://github.com/rudderlabs/rudder-config-schema/commit/860a9bb6e6e5d7aceacb83c6a0b7792e88705a71)) + ## [1.92.0](https://github.com/rudderlabs/rudder-config-schema/compare/v1.91.0...v1.92.0) (2024-09-19) diff --git a/package-lock.json b/package-lock.json index c01b63ca0..fa34d5a0b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "rudder-config-schema", - "version": "1.92.0", + "version": "1.92.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "rudder-config-schema", - "version": "1.92.0", + "version": "1.92.1", "license": "MIT", "dependencies": { "ajv": "^8.12.0", diff --git a/package.json b/package.json index 81eb7f18b..3dbd3ecdb 100755 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "rudder-config-schema", - "version": "1.92.0", + "version": "1.92.1", "description": "", "main": "src/index.ts", "private": true,