-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate the GitHub checks API #89
Comments
|
Other ideas of things you can create on a PR:
Unfortunately none of these allow you to easily link back to PerfCheck. The only ways to link back to PerfCheck seems to be to create or edit a Check or a Comment. |
Hmmm, I wonder how CircleCI achieves their direct link to circleci.com from the checks interface? |
Maybe they purposefully don't use the new checks API unless you opt-in to it: https://circleci.com/docs/2.0/enable-checks/ |
It might be helpful to separate these two needs:
|
Ah yes, the current way of implementing checks is by using the Status API. You register a webhook and then use the Status API to set a status for a commit sha. That has a target URL to link back to the CI. I'm guessing they'll show the statuses for the last commit in the PR. |
We're looking for a way to allow easy interaction between Perf Check and GitHub pull requests. It's possible that the checks API is a fit even though Perf Check is not a traditional CI service.
The text was updated successfully, but these errors were encountered: