Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when using deprecated SASL mechanisms #62

Merged
merged 1 commit into from
Sep 28, 2022

Commits on Jul 16, 2022

  1. Warn when using deprecated SASL mechanisms

    Mark obolete SASL mechanisms as deprecated (fixes GH-55):
    * This is a backwards-compatible alternative to the approach in GH-58
      (don't require and add the deprecated authenticators automatically).
      We can use that incompatible approach in a later version.
    * Warn every time a deprecated mechanism is used.
    * Warnings can be disabled with `warn_deprecation: false`
    * Fixes GH-56: delay loading standard gem dependencies until
      `#initialize`, and convert the gems to development dependencies.
    
    Additionally:
    * Adds basic tests for every authenticator (to avoid another GH-52!)
    * Fixes a frozen string bug in DigestMD5Authenticator.
    * Fixes constant resolution for exceptions in DigestMD5Authenticator.
    * Can register an authenticator type that responds to #call (instead of
      #new).  I was originally going to register deprecated authenticators
      with a Proc that required the file and issued a warning, but I decided
      to put everything into the initializer instead.  `#authenticator`
      needed to be updated to safely delegate all args, and I left this in.
    
    The DIGEST-MD5 bug was originally reported, tested, and fixed by
    @singpolyma here: nevans/net-sasl#3.
    
    Co-authored-by: Stephen Paul Weber <[email protected]>
    nevans and singpolyma committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    d466c2e View commit details
    Browse the repository at this point in the history