Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemAct extentions #enter/#exit hooks #3

Open
nyarly opened this issue Mar 3, 2019 · 1 comment
Open

SemAct extentions #enter/#exit hooks #3

nyarly opened this issue Mar 3, 2019 · 1 comment

Comments

@nyarly
Copy link
Collaborator

nyarly commented Mar 3, 2019

It seems like the Extension enter and exit hooks are only called in the EachOf operator. The documentation says (and I agree) that they should be called when arriving at and leaving a TripleConstraint.

Specifically, I'm trying to implement a Ruby version of ShexMap, and it's important to be able to group variable mappings into "domains" that separate repeated bindings of a variable. Eric's JS implementation has a kind of intermediate representation with lists of objects, where the JSON objects are analogous to the domains I'm talking about.

This is mostly an intent-to-PR, but I wanted to be sure that I'm reasoning correctly here and that there isn't a reason that semantic_actions enter and exit aren't called by every TripleConstraint.

@gkellogg
Copy link
Member

gkellogg commented Mar 4, 2019

Have at it. The extension stuff was prospective, and can't really handle the real semantics.

I haven't had time to work on this gem for quite a while, and don't know when I'll get back to it, so you're welcome to jump in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants