Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the purpose of Passkey#label #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asavageiv
Copy link

@asavageiv asavageiv commented May 4, 2024

Related to #56

Copy link
Contributor

@tcannonfodder tcannonfodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s keep the note that it’s required, and that you’ll want to scope it as well & ensure uniqueness. But adding this additional context is a great idea!

@asavageiv
Copy link
Author

asavageiv commented May 5, 2024

Let’s keep the note that it’s required, and that you’ll want to scope it as well & ensure uniqueness. But adding this additional context is a great idea!

Thanks for the review! Isn't it already in the "required" section? I'm happy to add it back if you think the extra emphasis is needed.

Can you explain the "scope it" part? What would that mean for the example? If I have "admin" and "user" resource types do I want "Admin - [email protected] Firefox" or something? Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants