Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "-" as delimiter in language codes #318

Open
agrajaghh opened this issue Oct 4, 2016 · 1 comment
Open

Support "-" as delimiter in language codes #318

agrajaghh opened this issue Oct 4, 2016 · 1 comment

Comments

@agrajaghh
Copy link

Currently the fallback language is determined form the language code using the underscore ("_") as a delimiter. At least Chrome is using a dash ("-") for me, so gettextFallbackLanguage() is returning null for e.g. "de-DE" instead of "de".

see: https://github.com/rubenv/angular-gettext/blob/master/dist/angular-gettext.js#L547
@atapas
Copy link

atapas commented Oct 7, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atapas @agrajaghh