You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the context exposes a variety of options for users to configure Comunica, such as an HTTP proxy for example, which is quite relevant to rdf-dereference, it makes sense for users to be able to provide the context to rdf-dereference.
That could be achieved by
Making IDereferenceOptions a broader type (e.g. extending it to include Record<string, any>) It would have to be that wide because not all context options are simple strings, some are functions or objects
Adding a separate context field to the IDereferenceOptions and passing that as the context to mediate
Of course, users could simply override Typescript to pass the context as they want currently as additional fields on the option argument, but this would make it explicit and indicate to users that it is a valid option.
The text was updated successfully, but these errors were encountered:
The
RdfDereferencerBase
passesoptions
of typeIDereferenceOptions
to thecbrd:Bus/RdfDereference
via themediate
function as the context.See here:
rdf-dereference.js/lib/RdfDereferencerBase.ts
Lines 25 to 30 in 645a126
Since the context exposes a variety of options for users to configure Comunica, such as an HTTP proxy for example, which is quite relevant to
rdf-dereference
, it makes sense for users to be able to provide the context tordf-dereference
.That could be achieved by
IDereferenceOptions
a broader type (e.g.extend
ing it to includeRecord<string, any>
) It would have to be that wide because not all context options are simple strings, some are functions or objectscontext
field to theIDereferenceOptions
and passing that as the context tomediate
Of course, users could simply override Typescript to pass the context as they want currently as additional fields on the
option
argument, but this would make it explicit and indicate to users that it is a valid option.The text was updated successfully, but these errors were encountered: