Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sweepTokens() function #44

Open
hellwolf opened this issue Jan 29, 2020 · 6 comments
Open

Add sweepTokens() function #44

hellwolf opened this issue Jan 29, 2020 · 6 comments
Labels
enhancement New feature or request sc

Comments

@hellwolf
Copy link
Collaborator

hellwolf commented Jan 29, 2020

We need a way to get COMP, and other tokens out of the rDAI contract.

One possible solution:

  • sweepTokens(address token) which is open for anyone to call, and sends any ERC20, excluding DAI and cDAI, to a manager account.
  • setTokenManager(address newManager) which is limited to only the current manager.

Requirements:

  • Ability to sweep tokens using a manager account
  • DAI and cDAI are not able to be swept
  • Tests are written to demonstrate functionality and edge-cases

Things to keep in mind:

  • The admin keys will be destroyed soon. The above funcitonality should work indefinitely using a tokenManager account without admin powers.
  • If you find gas optimizations and would like to implement them, let us know and we can increase the bounty, or make a new one.

Bounty amount: 300 DAI

@hellwolf hellwolf added enhancement New feature or request sc labels Jan 29, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 600.0 DAI (600.0 USD @ $1.0/DAI) attached to it as part of the rtoken-project fund.

@pi0neerpat pi0neerpat changed the title Implement DAI style permit function Add sweepTokens() function Mar 29, 2021
@pi0neerpat pi0neerpat reopened this Mar 29, 2021
@pi0neerpat
Copy link
Contributor

PLEASE NOTE: the bounty amount is 300 DAI, not 600 DAI

@pi0neerpat
Copy link
Contributor

Just to make sure, this is only for the rDAI contract?

Not sure what you mean?

@CrystalPony
Copy link
Contributor

CrystalPony commented Mar 30, 2021

I've implemented the sweepTokens and tokenManager functionality as described, I did not write tests though.

#70

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 265 years, 7 months from now.
Please review their action plans below:

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

⚡️ A tip worth 400.00000 DAI (400.0 USD @ $1.0/DAI) has been granted to @CrystalPony for this issue from @pi0neerpat. ⚡️

The sender had the following public comments:

Great work!

Nice work @CrystalPony! Your tip has automatically been deposited in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sc
Projects
None yet
Development

No branches or pull requests

4 participants