Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade redux-persist-transform-immutable #38

Open
aghoneim92 opened this issue Feb 27, 2018 · 8 comments
Open

Upgrade redux-persist-transform-immutable #38

aghoneim92 opened this issue Feb 27, 2018 · 8 comments

Comments

@aghoneim92
Copy link

aghoneim92 commented Feb 27, 2018

redux-persist-transform-immutable v4 uses transit-js, which takes up 18kb of the bundle size, gzipped and minified. It would be nice to use v5 which uses a much lighter library. I could open a PR for this but wanted to know if it would break anything :)

@chrisgbaker
Copy link

Very interested in this as well

@chrisgbaker
Copy link

What is needed to do this? I can go ahead and get the ball rolling.

@aghoneim92
Copy link
Author

@chrisgbaker I have already upgraded it in a fork on my account. After upgrading redux-persist-transform-immutable, there was a bug in the new library it used instead of transit-js where it tried to instantiate classes without new, this caused a runtime error with Babel-compiled projects. I also upgraded that and added everything to this branch:
https://github.com/aghoneim92/redux-persist-immutable/tree/upgrade-remotedev-serialize

@chrisgbaker
Copy link

@aghoneim92 Nice! Any chance we could get a PR into here for a release?

@chrisgbaker
Copy link

@aghoneim92 thoughts on that PR?

@chrisgbaker
Copy link

What needs to be done to get @aghoneim92's changes merged and a new release cut? Still very interested in having the dependency updated so I can drop transit-js from my bundle.

@aghoneim92
Copy link
Author

@chrisgbaker #37 and #41 are both open, but the library doesn't seem to be active or maintained anymore. If we couldn't get this merged, I suggest you link to my fork or your own fork of that one with a github value in your package.json

@FoxxMD
Copy link

FoxxMD commented Jul 2, 2020

Hey in case anyone comes across this you can use this package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants