Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutablejs as peerDependency #2

Open
ntucker opened this issue Sep 16, 2016 · 1 comment
Open

Immutablejs as peerDependency #2

ntucker opened this issue Sep 16, 2016 · 1 comment

Comments

@ntucker
Copy link

ntucker commented Sep 16, 2016

I imagine anyone using this library will already be installing immutable.js so maybe you should have it as peerDependency so the same install is used in this package.
@rt2zz
Copy link
Owner

rt2zz commented Sep 16, 2016

👍

I have bad memories of peer deps from npm 2 days. But I suppose in this case, it would always be better to grab the peer dep than to end up with two versions of immutable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ntucker @rt2zz