-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Shiny examples testing automation #87
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR contains a lot of PNG files, I strongly recommend that you run optipng *.png
on them to (significantly) reduce the file sizes.
Using optipng will actually break the tests, because for testing, the PNG files are compared byte-for-byte. |
Bummer. Is it possible to split these tests into a different repo then? Just asking... 1839 files sounds like a lot to me. |
True, that is a lot to put into this repo. We'll think about ways to keep the results separate. |
I'll look into it and then discuss with Winston how we can keep it small and still useful. |
a submodule may be the best idea: https://git-scm.com/book/en/v2/Git-Tools-Submodules |
In case anyone is curious, the total size of these image files is about 38 Mb > sum(sapply(Sys.glob("*/tests/mytest-expected/*.png"), file.size)) / 1000000
[1] 38.19511 |
shalu tiwari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
No description provided.