Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement async #204

Closed
trestletech opened this issue Nov 10, 2017 · 4 comments
Closed

Implement async #204

trestletech opened this issue Nov 10, 2017 · 4 comments

Comments

@trestletech
Copy link
Contributor

Following httpuv's implementation of async, we should add an async implementation to plumber endpoints/filters.

@trestletech trestletech added this to the v0.5.0 milestone Nov 10, 2017
@schloerke
Copy link
Collaborator

Closed in #248

@jeffkeller87
Copy link

FYI, there is a low-level and somewhat artificial performance issue in the parallel package on Linux. In effect, it puts a 35-45ms floor on data transfers between parallel socket connections.

For most parallel use-cases this penalty isn't noticeable. But for use-cases like plumber it is often quite noticeable if you are looking to achieve industry acceptable levels of API performance (which you probably are if you're going parallel). This has also been brought up regarding the future package: futureverse/future#437

I'd love to see the plumber community press R-devel to implement the fix, since we are the sort of use-case affected. I unfortunately do not have the skills to contribute such a low-level change to parallel.

@meztez
Copy link
Collaborator

meztez commented Dec 22, 2020

Even if they implement the fix, it would not impact plumber since plumber relies on libuv from httpuv package.

TCP_NODELAY would have to be enabled from httpuv library.

@jeffkeller87
Copy link

My bad. I saw references to promises and assumed the future package was involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants