Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnote inside of a table is not popping up in the right place. #411

Closed
RMRubert opened this issue Oct 6, 2021 · 4 comments
Closed

Footnote inside of a table is not popping up in the right place. #411

RMRubert opened this issue Oct 6, 2021 · 4 comments
Labels
bug 🐛 Something isn't working distill.pub Concerns upstream lib

Comments

@RMRubert
Copy link

RMRubert commented Oct 6, 2021

So, if you put a footnote inside of a table, this one pops up at the start of the page. If the table is at the start of the article you might be lucky to see it, otherwise there is no chance. I have my own CSS applied but I think this problem happens any time.

---
title: "Welcome to My Blog"
description: |
  Welcome to our new blog, My Blog. We hope you enjoy 
  reading what we have to say!
author:
  - name: Nora Jones 
    url: https://example.com/norajones
    affiliation: Spacely Sprockets
    affiliation_url: https://example.com/spacelysprokets
date: 10-01-2021
output:
  distill::distill_article:
    self_contained: false
citation: false
---

```{r setup, include=FALSE}
knitr::opts_chunk$set(echo = FALSE)

# Learn more about creating blogs with Distill at:
# https://rstudio.github.io/distill/blog.html

```

When I will have doubts about an artist being one or another genre, I will make myself the question, *if I was the Radio Station DJ[^1] of the genre, will I play it next to the master song?* If they couldn't be played next to any form song, they would be exiled into the "other" tag.

[^1]: Test 1

|     Genre        | Songs |            Form Song             |
|:----------------:|:-----:|:--------------------------------:|
| alternative rock |  393  |                Muse - Resistance |
|     ambient[^2]  |  19   |          Mauro Picotto - Adiemus |
|      blues       |  11   |          Leonard Cohen - Suzanne |
|   classic rock   |  710  |  Dire Straits - Sultans of Swing |

[^2]: Test 2

imagen

@RMRubert
Copy link
Author

RMRubert commented Oct 6, 2021

I think I screwed up with the github markdown :/ Sorry about that

@cderv cderv added the bug 🐛 Something isn't working label Oct 7, 2021
@cderv
Copy link
Collaborator

cderv commented Oct 7, 2021

I can reproduce this. This is something related to HTML / JS / CSS - I don't think footnotes in table are correctly supported.

Thanks for spotting that.

Note that in my case, when copy pasting your RMD into a single file and render, I get the footnote to be closer to the table. But not below the footnote.
image

I think I screwed up with the github markdown :/ Sorry about that

I edited. Here is advice on how to format: https://yihui.org/issue/#please-format-your-issue-correctly

@cderv
Copy link
Collaborator

cderv commented May 4, 2022

So after looking around, I believe this is an issue within distill.pub directly: distillpub/template#105

I'll see if I can port a fix in our version, but usually it is best if this is fixed upstream

@cderv cderv added the distill.pub Concerns upstream lib label May 4, 2022
@cderv cderv moved this to Backlog in R Markdown Team Projects May 4, 2022
@cderv cderv moved this from Backlog to In Progress in R Markdown Team Projects May 4, 2022
@cderv cderv closed this as completed in a7b263f May 4, 2022
Repository owner moved this from In Progress to Done in R Markdown Team Projects May 4, 2022
@cderv
Copy link
Collaborator

cderv commented May 4, 2022

This should be fixed in the dev version of distill. Footnotes tooltip should correctly be placed now when inside tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working distill.pub Concerns upstream lib
Projects
Archived in project
Development

No branches or pull requests

2 participants