Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot failure and lesser issues #543

Closed
V0ldek opened this issue Oct 1, 2024 · 2 comments · Fixed by #549
Closed

Dependabot failure and lesser issues #543

V0ldek opened this issue Oct 1, 2024 · 2 comments · Fixed by #549
Labels
type: reliability Tests, code quality
Milestone

Comments

@V0ldek
Copy link
Member

V0ldek commented Oct 1, 2024

Dependabot hasn't been working for quite a while apparently, without sending me any error messages at any point.

  1. rsonpath-test has a separate dependabot workflow but it's part of the main workspace. This doesn't work and is an error. What we actually want is rsonpath-test-codegen to be dependabotted separately, as that's excluded from the workspace.
    a) Why is it excluded from the workspace? I don't actually remember, need to double check if that's what we want.

EDIT:
I remember now, both test and test-codegen should be out of the main workspace because they pollute the dependencies in Cargo.lock.

  1. In rsonpath:
Please check your configuration as there are groups where no dependencies match:
- dev-deps

This can happen if:
- the group's 'pattern' rules are misspelled
- your configuration's 'allow' rules do not permit any of the dependencies that match the group
- the dependencies that match the group rules have been removed from your project

I have no idea why this happens, there clearly were available dev dependencies in rsonpath-lib to update...

  1. The main failure:
updater | 2024/10/01 23:25:57 ERROR <job_894385614> On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)
	modified:   crates/rsonpath-benchmarks (modified content)

no changes added to commit (use "git add" and/or "git commit -a")

Zero idea what's going on, need to investigate.

@V0ldek V0ldek added the type: reliability Tests, code quality label Oct 1, 2024
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Tagging @V0ldek for notifications

@V0ldek V0ldek mentioned this issue Oct 2, 2024
3 tasks
@V0ldek V0ldek modified the milestones: lib v1.0.0, v1.0.0 Oct 2, 2024
@V0ldek V0ldek moved this from Todo to In Progress in Active rq development Oct 2, 2024
@github-actions github-actions bot added acceptance: go ahead Reviewed, implementation can start and removed acceptance: triage Waiting for owner's input labels Oct 2, 2024
@V0ldek
Copy link
Member Author

V0ldek commented Oct 2, 2024

I don't know if this is solvable without removing benchmarks as a submodule.

That doesn't actually sound like such a bad idea... Submodule wonkiness has been a PitA for quite a while. It might make sense to have them in the same repo but put it outside of the workspace and version them separately. It would also stop it from rotting, as currently its pipeline has been failing for sooo long, mainly due to the desync between pushing to the main repo vs pushing to the benchmarks repo.

@github-project-automation github-project-automation bot moved this from In Progress to Merged in Active rq development Oct 25, 2024
@github-actions github-actions bot removed the acceptance: go ahead Reviewed, implementation can start label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: reliability Tests, code quality
Projects
Development

Successfully merging a pull request may close this issue.

1 participant