Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider auto-sync flag when applying settings #386

Closed
mathieucarbou opened this issue Apr 11, 2017 · 3 comments
Closed

Consider auto-sync flag when applying settings #386

mathieucarbou opened this issue Apr 11, 2017 · 3 comments

Comments

@mathieucarbou
Copy link
Contributor

See: https://groups.google.com/forum/#!msg/midi2lr/siYOF2WL8UY/azWt0SKwCwAJ

Right, the patch that I added go through applying develop settings now and for that we have to target an image.
The problem is not new: other settings are also applied only to the target image.

The culprit is this line in client utilities I think:

LrApplication.activeCataloggetTargetPhotoapplyDevelopSettings():():(settings)

Rory: I don't know if we can check the status of the auto-sync switch. Do we ? If we can, we could add an if statement that applies to all with: catalog:getTargetPhotos().

I am also wondering if just using catalog:getTargetPhotos() would take in consideration the auto-sync switch…

@rsjaffe
Copy link
Owner

rsjaffe commented Apr 18, 2017

No, we can't check the auto-sync switch.

@mathieucarbou
Copy link
Contributor Author

mathieucarbou commented Apr 18, 2017

And do you know if catalog:getTargetPhotos() (which is different than getting the selected photos) would consider it ? Meaning that if no tenabled, the list would have 0 or 1 item and if enabled, the list would have 0..N items ?

If it works like that, then we could use catalog:getTargetPhotos() instead of trying to get the target photo

@rsjaffe rsjaffe removed the Bug label Sep 24, 2017
@rsjaffe
Copy link
Owner

rsjaffe commented Jan 5, 2018

Duplicate of #414

@rsjaffe rsjaffe marked this as a duplicate of #414 Jan 5, 2018
@rsjaffe rsjaffe closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants