Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs-love] Singularity Registry Server add contributors to collection #8

Open
vsoch opened this issue Mar 10, 2020 · 0 comments
Open
Labels
needs-love A project or idea submit that needs love, or is making a request for help

Comments

@vsoch
Copy link
Collaborator

vsoch commented Mar 10, 2020

Description

A user has requested that an admin (a super user to be specific) is allowed to add custom users to a collection contributors or owners. This is something that seems reasonable in that it can be done with the manage.py (direct interaction with the container) but this is different from the user interface. For this needs love issue, if someone has some experience with jinja2 and python, we would want to update the view to allow this functionality, and make sure it doesn't break teams. See singularityhub/sregistry#280.

How can we help?

  • Update the shub/apps/main/templates/collections/_collection_settings_users.html and matching views in shub/apps/main/views/collections.py to allow for a super user to add users to be contributors or owners. I also think this should be set to be allowed (or not) as a global environment variable, with the default not allowing it (I don't see it being a pattern for any other registry, although I'm definitely not the super user there!)

Please open up discussion here if you have any questions and would like to work on this issue to learn about Django, containers, or jinja2.

@vsoch vsoch added needs-love A project or idea submit that needs love, or is making a request for help matched indicates that a needs-love issue has found someone to help! labels Mar 10, 2020
@github-actions github-actions bot removed matched indicates that a needs-love issue has found someone to help! needs-love A project or idea submit that needs love, or is making a request for help labels Mar 11, 2020
@vsoch vsoch added the needs-love A project or idea submit that needs love, or is making a request for help label Mar 11, 2020
@github-actions github-actions bot removed the needs-love A project or idea submit that needs love, or is making a request for help label Mar 11, 2020
@vsoch vsoch added the needs-love A project or idea submit that needs love, or is making a request for help label Mar 11, 2020
@github-actions github-actions bot removed the needs-love A project or idea submit that needs love, or is making a request for help label Mar 11, 2020
@vsoch vsoch added the needs-love A project or idea submit that needs love, or is making a request for help label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-love A project or idea submit that needs love, or is making a request for help
Projects
None yet
Development

No branches or pull requests

1 participant