Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Angular 13 #62

Open
10Bude10 opened this issue Nov 11, 2021 · 5 comments
Open

Incompatibility with Angular 13 #62

10Bude10 opened this issue Nov 11, 2021 · 5 comments

Comments

@10Bude10
Copy link

10Bude10 commented Nov 11, 2021

IMPORTANT:
Upgrading angular 12 to 13 fails in migration step. Ngx-custom-validators have to be updated to angular@13 as well
$ npx @angular/cli@13 update @angular/core@13 @angular/cli@13
Using package manager: 'npm'
Collecting installed dependencies...
Found 80 dependencies.
Package "ngx-custom-validators" has an incompatible peer dependency to "@angular/common" (requires "~11.0.0" (extended), would install "13.0.1").
Package "ngx-custom-validators" has an incompatible peer dependency to "@angular/core" (requires "~11.0.0" (extended), would install "13.0.1").
Package "ngx-custom-validators" has an incompatible peer dependency to "@angular/forms" (requires "~11.0.0" (extended), would install "13.0.1").
× Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.

Steps to reproduce and a minimal demo
Install angular@13 and [email protected]

Current behavior
Migration fails. Can't start application

Expected/desired behavior
Should work with angular 13

Environment information

  • Angular Version: 13
  • Typescript version: 4.4.4
  • npm version: 6.14.14
  • Node Version: 14.17.5
@manast
Copy link

manast commented Jun 3, 2022

It actually fails already with angular 11:

 Package "ngx-custom-validators" has an incompatible peer dependency to "@angular/common" (requires "~11.0.0" (extended), would install "11.2.14")

@ct-dixit
Copy link

I think no one is maintaining this repo from last two year.

@hpardess
Copy link

npm WARN While resolving: @angular/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/zone.js
npm WARN   zone.js@"~0.11.4" from the root project
npm WARN   2 more (@angular/core, ngx-custom-validators)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer zone.js@"~0.10.3" from @angular/[email protected]
npm WARN node_modules/ngx-custom-validators/node_modules/@angular/core
npm WARN   @angular/core@"~11.0.0" from [email protected]
npm WARN   node_modules/ngx-custom-validators
npm WARN   5 more (@angular/common, @angular/forms, ...)
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/zone.js
npm WARN   peer zone.js@"~0.10.3" from @angular/[email protected]
npm WARN   node_modules/ngx-custom-validators/node_modules/@angular/core
npm WARN     @angular/core@"~11.0.0" from [email protected]
npm WARN     node_modules/ngx-custom-validators
npm WARN     5 more (@angular/common, @angular/forms, ...)

Angular v13.1.0
ngx-custom-validators v11.0.1

@jeetenparmar
Copy link

@hpardess Did you find the solution or alternative?

@pedrohills
Copy link

run:

npm install --save --force @narik/custom-validators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants