Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Validator to check if a value is included (or not) in an array #42

Closed
beradrian opened this issue Oct 13, 2020 · 3 comments
Closed

[Feature request] Validator to check if a value is included (or not) in an array #42

beradrian opened this issue Oct 13, 2020 · 3 comments

Comments

@beradrian
Copy link

It would be nice to have a validator to check if the control value is included or not in an array, something like [includedIn]="array" or [notIncludedIn]="array". The second one will be useful to check the uniqueness of a value.
If interested I can submit a PR.
@rsaenen
Copy link
Owner

rsaenen commented Oct 14, 2020

I recommand you to check #37

As long as a validators comes with testing, I can merge it, thanks.

@beradrian
Copy link
Author

beradrian commented Oct 16, 2020 •
edited
Loading

I created PR #43 with tests included.

@beradrian
Copy link
Author

PR #43 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beradrian @rsaenen