Try to produce a clean/sequential DOM walk for the initial snapshot #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm detecting a lot of out-of-order-id full snapshots in the wild but find them very hard to recreate (out of order in the sense that ids don't follow a sequential pattern as you walk the snapshot depth first).
The only thing I can imagine is that it has something to do with DOM mutations happening during the snapshotting (so that an already snapshotted DOM node appears later in the walk under another branch of the DOM). The initial commit in this pull request has the effect of fixing the out of order IDs, but maybe it could introduce other problems, so it would be great to get someone else's input on this!