Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude pre load & icon #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

exclude pre load & icon #46

wants to merge 1 commit into from

Conversation

jokeewu
Copy link

@jokeewu jokeewu commented Sep 20, 2020

No description provided.

@eoghanmurray
Copy link
Contributor

Hi @jokeewu
The usecase may be covered by very recent code I was working on;
slimDOMOptions.script and slimDOMOptions.headFavicon
These are off by default and await acceptance of a corresponding pull request rrweb-io/rrweb#286
The difference with this pull is that these elements are excluded from the DOM mirror at recording time.
Maybe the slimDOMOptions.script exclusion should be on by default, as is the case here?

This pull request isn't mutually exclusive with the slimDOM one — did the presence of script preloads cause you actual problems in replay?

Yuyz0112
Yuyz0112 reviewed Sep 28, 2020
View reviewed changes
src/rebuild.ts
}

// exclude icon load
if (tagName === 'link' && n!.attributes!.rel === 'icon') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the problem if we rebuild a link element with icon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuyz0112 Yuyz0112 Yuyz0112 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jokeewu @eoghanmurray @Yuyz0112