Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs in example 16 #93

Open
4 tasks
rpoleski opened this issue Aug 10, 2023 · 2 comments
Open
4 tasks

bugs in example 16 #93

rpoleski opened this issue Aug 10, 2023 · 2 comments
Labels

Comments

@rpoleski
Copy link
Owner

  • Delta t_0 is not saved anywhere

Things that are borderline between bug and missing enhancement:

  • print script version
  • save fixed parameters
  • warnings if plots will overwrite existing files
@rpoleski rpoleski added the bug label Aug 11, 2023
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Oct 25, 2023
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Oct 25, 2023
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Oct 25, 2023
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Oct 25, 2023
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Oct 26, 2023
@rapoliveira
Copy link
Contributor

@rpoleski I have addressed all the bugs/improvements listed here. Moreover, I added a boolean option to the yaml input file, under "second Y axis" of the best model plot, in order to recalculate the magnifications if the provided list is out of range.

Please take a look at it and send any suggestions before I make the pull request.

@rpoleski
Copy link
Owner Author

Nice job!
I would suggest one change. You added a new option recalculate magnification ticks. There will be a problem if the user provides both that and magnifications: which one should be used? I would suggest not to add that option, but instead allow, e.g., magnifications: optimal. And second thing (sic!) - if optimal is provided, then labels are not allowed.

rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Oct 27, 2023
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants