Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xallarap - after merge TO DO list #90

Open
2 of 7 tasks
rpoleski opened this issue Jun 30, 2023 · 0 comments
Open
2 of 7 tasks

Xallarap - after merge TO DO list #90

rpoleski opened this issue Jun 30, 2023 · 0 comments

Comments

@rpoleski
Copy link
Owner

rpoleski commented Jun 30, 2023

Some useful changes to be done after xal branch is merged:

  • Example 16 - add xallarap parameters to _set_default_parameters() and _check_fixed_parameters()
  • change ModelParameters._check_valid_combination_1_source_standard() so that it would be useful for Keplerian lens motion (i.e., remove xi_ and run tests on that).
  • Add on-sky angles (RA, Dec) calculations (requested by @jenniferyee; also could be useful for RV follow-up).
  • Example with calculations of Kepler III law.
  • Warning for stupid values of angles etc. - REMOVE
  • Left/right hand system - see eq. 11 in the EXOFAST 2.0 paper
  • consider adding sqrt(e)*sin(omega) and sqrt(e)*cos(omega) parametersization (ref - p.3 right column)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant