Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Relative Tolerance of VBBL Will Lead to Significant Speedup of MulensModel in High Magnification Region #162

Open
zhangjiyuan22 opened this issue Dec 9, 2024 · 0 comments

Comments

@zhangjiyuan22
Copy link

Currently, explicitly setting relative error goal of VBBL (RelTol) hasn't been incorporated into MulensModel (see source/VBBL/VBBinaryLensingLibrary_wrapper.cpp, only setting absolute error goal, Tol, is implemented). If we set absolute error goal to 1e-2 and relative error goal to 1e-3, then when magnification is larger than 10, the relative error goal will be met first and the computation can stop earlier.

The following figure shows the speedup from RelTol=0 (the default value in VBBL if you don't set it explicitly) to setting RelTol=1e-3 (sufficient for ground base observation). The speedup is 5(10) at magnification 100(200).
RelTol_speedup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant