Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with upload to PyPI #133

Closed
rpoleski opened this issue Apr 27, 2024 · 4 comments
Closed

issue with upload to PyPI #133

rpoleski opened this issue Apr 27, 2024 · 4 comments

Comments

@rpoleski
Copy link
Owner

GIthub action that uploads to PyPI failed:

https://github.com/rpoleski/MulensModel/actions/runs/8857835510

@ketozhang Can you help with that one?

@ketozhang
Copy link
Contributor

Issue is not being able to build the wheel for Python 3.7 for MACOS. 3.7 has been long outdated.

We have a choice to pursue trying a different method to build the 3.7 wheels or not. If we do not, existing 3.7 users could still use MulensModel, we just don't have wheels for them.

@rpoleski
Copy link
Owner Author

So changing:

cibw_build: [cp37-*, cp38-*, cp39-*, cp310-*, cp311-*]

->

cibw_build: [cp38-*, cp39-*, cp310-*, cp311-*]

should work?

@ketozhang
Copy link
Contributor

ketozhang commented Apr 28, 2024

Yep that works. I added a PR for this #134, since I wanted to add changes so that next time you could've uploaded the successful wheels manually.

@rpoleski
Copy link
Owner Author

Thanks! New version is already on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants