Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center of mass versus center of magnification #115

Open
jenniferyee opened this issue Dec 28, 2023 · 1 comment
Open

Center of mass versus center of magnification #115

jenniferyee opened this issue Dec 28, 2023 · 1 comment

Comments

@jenniferyee
Copy link
Collaborator

For binary lenses, we did find the origin as the center of mass. We also allow the user to specify point_source_point_lens as a magnification method. For the case of wide binaries, the difference between the center of mass and the center of magnification may be a problem when switching between the point_source_point_lens and binary lens magnification methods. We should definitely check this and maybe write a unit test for it.

@rpoleski
Copy link
Owner

rpoleski commented Jan 1, 2024

Maybe we should add a keyword origin or reference_frame to ModelParameters().

Honestly, when I need only a reparametrization, then I use re-parametrization available in example 16: see changes in this branch. So far, all functions I needed, are available in ex16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants