Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks for Jobs and Transformations inside Jobs not working #44

Open
GoogleCodeExporter opened this issue Mar 13, 2015 · 21 comments
Open

Comments

@GoogleCodeExporter
Copy link

First, let me say that this is a great tool, thank you very much for doing 
this. 

Now, I seem to have a little issue when generating documentation for Jobs which 
contain other jobs or transformations. The generated hyperlinks on the icon 
comes out wrong, e.g. as "cookbook/html/.html". See attached screenshot, the 
status line was captured while hoovering over the Job entry on the right. 

The generated <a> looks like this:
<a class="&#xA;entry-label&#xA;                    " style="&#xA;               
     top:365px;&#xA;                    left:543.6666666666666px;&#xA;          
      " href=".html">Parallel create ITNM config / seed files</a>

I've tried on Solaris and OS X, on each with r45 and r76 and the behavior seems 
to be the same everywhere. 


I'm not exactly sure whether this should be an anchor on the page or a link to 
the page of the included Job/Transformation... I'd prefer the latter if this 
feature isn't fully defined yet :)

Sorry I can't easily attach a test case as these files contains confidential 
information. 

Christian



Original issue reported on code.google.com by [email protected] on 23 Nov 2011 at 4:28

Attachments:

@GoogleCodeExporter
Copy link
Author

Same problem here.

Can someone help plz?

Original comment by [email protected] on 7 Dec 2011 at 11:17

@GoogleCodeExporter
Copy link
Author

Hi Guys, I can't seem to reproduce it. Can you please send me:
- version of cookbook (rev no)
- OS you use to run the cookbook job (be as specific as possible, include 
distro info etc)
- exact syntax you use to invoke cookbook (for example, the exact Kitchen 
command line)

Original comment by roland.bouman on 7 Dec 2011 at 11:22

@GoogleCodeExporter
Copy link
Author

I'm working with r76
the OS is 
windows XP
Version 2002
Service Pack 3


the cookbook is ran from inside spoon.bat
So I can't reproduce the exact command syntax

Thanks anyway!

Original comment by [email protected] on 7 Dec 2011 at 11:32

@GoogleCodeExporter
Copy link
Author

Hi yvesci, 

thanks! But can you list the exact way you specify the parameter values for 
INPUT_DIR and OUTPUT_DIR though? Do they have a trailing slash or backslash for 
example, are they absolute paths, etc...

Original comment by roland.bouman on 7 Dec 2011 at 11:38

@GoogleCodeExporter
Copy link
Author


INPUT_DIR   C:\cookbook_dev\exported_repo\public\*\*\*

sorry for the asterisks but it's classified information:s. But that's the 
structure anyway.

OUTPUT_DIR  C:\cookbook_dev\cookbook_output 
SAXON           ./libext/saxon8.jar 

Original comment by [email protected] on 7 Dec 2011 at 11:43

@GoogleCodeExporter
Copy link
Author

Ok yvesci, so if i understand correctly, then instead of the *'s there's a 
regular identifier (just letters, underscores and digits), and no trailing 
slash or backslash?

I'll try and get to this as soon as possible, but the agenda is a bit crazy 
atm. Could it wait till say the weekend?

Original comment by roland.bouman on 7 Dec 2011 at 11:51

@GoogleCodeExporter
Copy link
Author

Thanks a lot. Of course the weekend is ok.


Thanks a lot in advance.

If you have any questions, I can give more info through a PM.
because I'm working on a Pentaho (BiSmart) project in Belgium.

Kind regards

Original comment by [email protected] on 7 Dec 2011 at 12:30

@GoogleCodeExporter
Copy link
Author

You can always send me email, [email protected]. If you do, then be sure 
to make it clear in the email message why you can't use a public tracker 
(otherwise I tend to send people back to either a public tracker of a public 
forum)

Original comment by roland.bouman on 7 Dec 2011 at 12:39

@GoogleCodeExporter
Copy link
Author

Hello Roland

Sorry I didn't look at this issue for a while and have seen your comments just 
now.

I think the issue may be that we're running Cookbook over a file repository, 
and the linked jobs/transformations are all given via the "specify by 
reference" field, which may be why Cookbook fails to obtain the file names.

Is running Cookbook over a file repository "as-is", without prior export even 
supposed to work? If yes, I'll build a test case for you.


Christian


Original comment by [email protected] on 13 Dec 2011 at 9:47

@GoogleCodeExporter
Copy link
Author

Ok here's how to reproduce (did it on OS X, but I specify it's 
platform-independent):

- Unzip attached file
- Configure contained directory as file repository
- Run platform equivalent of:

/Applications/Kettle/kitchen.sh 
-file:/opt/cookbook-svn/r76/pdi/document-folder.kjb 
-param:INPUT_DIR=/Users/rc/testrep  -param:OUTPUT_DIR=/tmp/doc 
-param:SAXON=/Applications/Kettle/libext/saxon9.jar

Expected result:
/tmp/doc/html/parent.kjb.html contains link to child.ktr.html

Obtained result:
".html" href in link:

a class="
                      entry-label
                      " style="
                      top:132px;
                      left:352.3333333333333px;
                  " href=".html">Transformation</a></div>

Thanks,
Christian 



Original comment by [email protected] on 13 Dec 2011 at 12:02

Attachments:

@GoogleCodeExporter
Copy link
Author

Google Code seriously lacks comment editing. The above "specify" should of 
course be "suspect" :)

Original comment by [email protected] on 13 Dec 2011 at 12:04

@GoogleCodeExporter
Copy link
Author

Hi, 

"the linked jobs/transformations are all given via the "specify by reference" 
field" 

can you please attach a screenshot to show me exactly what you mean by this? 
Thanks!

And thanks for the test case, I'll do my best to find some time to look into it.

Original comment by roland.bouman on 13 Dec 2011 at 1:12

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

In the parent job when picking a subtransformation or -job to launch, there are 
three options to specify the file: filename, name and directory or reference 
(i.e. a path idependent of the filesystem where / is the root of *the 
repository* and not the file system)

Original comment by [email protected] on 13 Dec 2011 at 1:32

Attachments:

@GoogleCodeExporter
Copy link
Author

Christian, thanks! There is a 100% probability that this is the cause.

I'll do my best to get this fixed this weekend.


Original comment by roland.bouman on 13 Dec 2011 at 1:36

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

Hello guys,

Was this issued ever addressed? I have the same problem here in r45 Linux RHEL

Thanks,
Rodrigo

Original comment by [email protected] on 3 May 2013 at 12:50

@GoogleCodeExporter
Copy link
Author

Are you using the "specify by reference" field? If so then it was not yet 
addressed.

Original comment by roland.bouman on 3 May 2013 at 12:52

@GoogleCodeExporter
Copy link
Author

Hi Roland,

Yes, we only use "specify by reference" in our projects. Is this going to be 
supported in the future?

Thanks
Rodrigo

Original comment by [email protected] on 6 May 2013 at 9:10

@GoogleCodeExporter
Copy link
Author

Hi Rodrigo, 

I'm not opposed to supporting it, but time is always a problem. Can you prepare 
a very simple example for me (job that calls another job, and a transformation, 
and transformation that calls a subtransformation), zip it and attach it to 
this issue? Then maybe I can take a look at the weekend to see what it would 
take to get this going.

Cheers, 

Roland

Original comment by roland.bouman on 6 May 2013 at 10:41

@GoogleCodeExporter
Copy link
Author

Sure, here you go.

I created one main job that call a main transformation and a sub job. The main 
transformation calls a sub job.

Cheers
Rodrigo

Original comment by [email protected] on 6 May 2013 at 2:50

Attachments:

@TTassoni
Copy link

Hi guys!
I am working with cookbook (pdi 6,1 CE) and have same problem. I export (thanx again, Roland) my DB legacy repository to a file repository with Krex. Jobs and transformation are calling other job and transformation setting Repository: specify by name property or Repository: specify by reference, and krex export them correctly. When i 'apply' kettle cookbook on these files, I have the problem.
But if (before run kettle cookbook) on the exported files I change the job step and transformation step setting Job filename to ${Internal.Job.Filename.Directory}/My_Other_Job_To_Call.kjb Kettle-cookbook do its work very well, the links are well-written and (obviously) work.
I do this workaround because my repository is small (and I have a short time for further investigation).
Hope this help someone.
Tommaso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants