Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing calls to the Buffer constructor with Buffer.from() #1

Open
gabrielschulhof opened this issue Aug 28, 2018 · 1 comment
Open

Replacing calls to the Buffer constructor with Buffer.from() #1

gabrielschulhof opened this issue Aug 28, 2018 · 1 comment

Comments

@gabrielschulhof
Copy link

new Buffer(...) is deprecated and unsafe. Would it be possible to replace calls to it with Buffer.from(...) in these places?
This was referenced Aug 28, 2018
Closed
Closed
@roytam1
Copy link
Owner

roytam1 commented Aug 28, 2018

all of them are in unit tests and there is no non-unittest code using such syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabrielschulhof @roytam1