Check if module is installed on external SD card

[pylerSM]

No description provided.

[rovo89]

It definitely makes sense to warn the user about this. But wouldn't it be a better experience to display such information in the UI? There is already some logic that disallows enabling modules which are not compatible with the current Xposed version (bottom of ModulesFragment.java). The same TextView could be used to display a hint that the module cannot be used. In that place, we could also use the flags in ApplicationInfo instead of checking the path.

Actually, the message needs to be refined a bit because it also applies to paid apps ("forward lock"). If possible, it should make clear that this is a technical hurdle, not an intentional "feature". But of course, the message shouldn't be too long either...

[pylerSM]

Firstly I would do this on log-level, then we could look on UI.

In that place, we could also use the flags in ApplicationInfo instead of checking the path.

Yes, for UI code it is much better solution.
Now it would require more code to get flags from app here, in logging so I think current implementation is not so bad.

About message.. maybe instead of "This module is installed on external SD card and it will NOT work" we can use "This module is not installed on the internal storage and it will NOT work".

Maybe add "Warning:" before message? Any ideas for clear and short message? @rovo89