Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncates lines in print view #9677 #9692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gcolpart
Copy link

@gcolpart gcolpart commented Nov 5, 2024

Fix #9677

@pabzm
Copy link
Member

pabzm commented Nov 7, 2024

Thank you! While trying to write a test I came up with a test message body, that isn't fixed by your change:

EsseevenietharumattotaminciduntesseQuiitaquenullarepellatRepellendusidvoluptatemcorruptiassumendaofficiaaetDolorembeataelaborumasperioresratione.

OptiodoloremtotamfugiatblanditiisexercitationemcorruptinecessitatibusoccaecatiNemodelenitiquiafugitutrepellendusFacilisteneturautidfacereRepellendusatquesitminimaminimaculpateneturidreiciendisVoluptasdignissimosdignissimosquodvoluptatibusexplicaboSedaliasasperioresmaioresoccaecatietnemo.

AliasquisquaminsedVeniamvelitconsecteturquitemporeanimiutautsapienteFugitteneturvoluptasquiaetfacere.

(It's just Lopem Ipsum without blanks.)

For these lines to be printed in full length, I have to use @media print{body{overflow-wrap: anywhere}}.

Could you please show which kind of text is printed properly with your suggested change?

And could you check if my CSS suggestion also fixes your example text?

Copy link

@pabzm, @alecpl
🛎️ This PR has had no activity in two weeks.

@pabzm
Copy link
Member

pabzm commented Nov 22, 2024

@gcolpart Are you still interested in this?

@gcolpart
Copy link
Author

Hello,

Thank you! While trying to write a test I came up with a test message body, that isn't fixed by your change:
[…]
(It's just Lopem Ipsum without blanks.)
For these lines to be printed in full length, I have to use @media print{body{overflow-wrap: anywhere}}.
Could you please show which kind of text is printed properly with your suggested change?

My patch is to fix issue #9677 for very long lines with spaces when I select zoom 200% in print settings., like :

Optiodolor emtotamfugiat blanditiisexercitat ionemcorruptinecessita tibusoccaecatiNemo delenitiquiafu gitutrepellendusFac ilisteneturautidf acereRepellendu satquesitminimamin imaculpatenetu ridreiciendisVolup tasdignissim osdignissi mosquodvoluptatib usexplicaboSedaliasas perioresma ioresoccae catietnemo.

It doesn't fix for very long lines without blanks .

And could you check if my CSS suggestion also fixes your example text?

I test your patch, it fixes a bug when printing with zoom 100% with very long lines without blanks

BUT :

Copy link

@pabzm, @alecpl
🛎️ This PR has had no activity in two weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic: "print" view truncates lines
2 participants