-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename composer.json.dist to composer.json #9279
Conversation
This will make working directly on source code more complicated. I normally have my composer.json file with additional packages/plugins added. I won't be able to do that. I need to investigate what options there are to fix that. One I found is use of |
[1] https://getcomposer.org/doc/03-cli.md#composer |
1a76637
to
8fc3bae
Compare
bin/installto.sh
Outdated
@@ -79,7 +79,8 @@ if (strtolower($input) == 'y') { | |||
} | |||
|
|||
foreach (['index.php', 'config/defaults.inc.php', 'composer.json-dist', 'jsdeps.json', 'CHANGELOG.md', 'README.md', 'UPGRADING', 'LICENSE', 'INSTALL'] as $file) { | |||
$command = 'rsync -a --out-format=%n ' . INSTALL_PATH . "$file $target_dir/$file"; | |||
$source_file = $file === 'composer.json-dist' ? 'composer.json' : $file; | |||
$command = 'rsync -a --out-format=%n ' . INSTALL_PATH . "$source_file $target_dir/$file"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures the composer.json
is downloaded still to composer.json-dist
as expected by https://github.com/roundcube/roundcubemail/blob/1.6.5/bin/update.sh#L177 update script.
I couldn't find more places to fix, but please review this PR carefully, there might be more install/update usecases/docs I might be not fully aware.
I created composer/composer#11784 but I don't expect it to be implemented soon or at all. The package I mentioned there is not of a great quality. However, I tested the |
@alecpl can I ask you to review this PR? Based on #9279 (comment) and composer/composer#11784 the |
8fc3bae
to
20e5797
Compare
I have rebased this PR. @alecpl, can you please check? According to the sources above, there are no other options, the only supported filename by composer is |
needed for #9241, for using this project/libs as a composer/Packagist dependency in general