Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does Docker have builds and not GitHub tags are pushed? #248

Open
williamdes opened this issue May 20, 2024 · 5 comments
Open

Why does Docker have builds and not GitHub tags are pushed? #248

williamdes opened this issue May 20, 2024 · 5 comments

Comments

@williamdes
Copy link
Contributor

@thomascube I noticed no new git tags are pushed but that the image gets updated.
What is the new process?

@thomascube
Copy link
Member

The github actions are not set up to create tags. Previously, tagging (and thus releasing) was a manual process which triggered builds on Docker Hub. Because of the new automation with Github actions, tags are no longer needed. That saying, suggestions how to extend our actions to create tags again are welcome.

@williamdes
Copy link
Contributor Author

That saying, suggestions how to extend our actions to create tags again are welcome.

Okay, thanks
I think having tags is good to know from what was thrown the workflow

@thomascube
Copy link
Member

We could consider to create tags for each version again but some questions come to my mind:

  • How to build new images if we make changes to the Dockerfile but the Roundcube version is unchanged?
    • Moving the Git tag?
    • Different versioning schema for Docker images?
  • Same question for periodic updates of the base image (php) without Roundcube version changes.
  • How to do auto-update as we currently do with the update.sh cron job?
    • Can github actions create tags?

@williamdes
Copy link
Contributor Author

We could consider to create tags for each version again but some questions come to my mind:

* How to build new images if we make changes to the Dockerfile but the Roundcube version is unchanged?

Trigger the same tag once more ?

  * Moving the Git tag?

This one is for me a bad option, avoid moving git tags.

  * Different versioning schema for Docker images?

* Same question for periodic updates of the base image (php) without Roundcube version changes.

* How to do auto-update as we currently do with the update.sh cron job?
  
  * Can github actions create tags?

Using git tags is quite easy and will do the trick
You can automate all this
Look at how I derived GitHub caching to do this here: https://github.com/sudo-bot/docker-phpmyadmin-snapshots/blob/main/.github/workflows/cron.yml

And when a release is published, then it is built: https://github.com/sudo-bot/docker-phpmyadmin-snapshots/blob/main/.github/workflows/publish.yml#L8

@pabzm
Copy link
Member

pabzm commented Nov 8, 2024

I don't quite understand this issue. Roundcubemail uses git-tags only for releases, if I am not mistaken. And these releases are picked up by update.sh. And the images are tagged with the version numbers, too.

Can someone explain what's missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants