Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some API suggestions #1

Open
vorner opened this issue Mar 17, 2017 · 0 comments
Open

Some API suggestions #1

vorner opened this issue Mar 17, 2017 · 0 comments

Comments

@vorner
Copy link

vorner commented Mar 17, 2017

Hello

I was reading through the code as it is already written (because I might find a use for it sometime soon) and I'd have a few suggestions, if I may (I wanted to discuss them first, before I start making pull requests).

Basically, it's almost what I need, except that I'd like to be able to both receive and send multipart messages ‒ not only receive them. Would you agree if I provided the code?

Furthermore, I noticed some TODO notes about using a Codec (https://github.com/rotty/zmq-tokio/blob/master/src/lib.rs#L122). I believe Codec is wrong thing to do (because it handles framing and ZMQ does framing already). I think the right thing to do is simply return the Vec's and convert them using .map() on the stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant