Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature instance size #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

petemill
Copy link

This allows any instance of a video found within content to override the default size (width and height) output for that video. Useful for sites where the video sizes differ amongst uses.

The ID segment of the input is parsed, and split by the string '##'. Content after that splitter is assumed to be size information. The size information is split by the character 'x' for width and height. (Note that a future PR coming very soon will allow this size information to be a single aspect-ratio value.)

An example:

@[vimeo](12345##600x400)
  • code
  • tests
  • lint and spec passes

@petemill petemill mentioned this pull request Aug 31, 2016
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant