Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle issues with generated function names #16

Open
2 tasks
minhnh opened this issue Apr 29, 2020 · 0 comments
Open
2 tasks

handle issues with generated function names #16

minhnh opened this issue Apr 29, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@minhnh
Copy link
Member

minhnh commented Apr 29, 2020

As discussed in #15 (specifically in #15 (review) and #15 (comment)), the following issues with generated function names should be better handled:

  • check names of generated functions to ensure that they are unique
  • ensure name used for function declaration, definition and function call are all the same

One way to deal with the 1st point is to utilise the built-in "unique name" generation to enforce uniqueness. I have tried this out a bit, however, and it seems to be non-trivial to ensure the 2nd point with this method. Specifically, I tried to create a function name template to provide an unique function name that are used in function declaration, definition, call templates. The generated strings are unfortunately all different for the different templates.

@scymtym @xwavex @svenschneider please add anything you notice

@minhnh minhnh added the enhancement New feature or request label Apr 29, 2020
@minhnh minhnh self-assigned this Apr 29, 2020
@minhnh minhnh changed the title Potential issues generated function names better handle issues with generated function names Apr 29, 2020
@minhnh minhnh changed the title better handle issues with generated function names handle issues with generated function names Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant