-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uses:
keyword is not currently supported
#33
Comments
That's... really odd. I'm sorry, I've never seen this happen before. I wonder if it's to do with how the action is set up. actions/checkout runs entirely out of a JS script: https://github.com/actions/checkout/blob/ac593985615ec2ede58e132d2e21d2b1cbd6127c/action.yml#L77-L80 But pr-preview-action it itself composed of sub-actions: Lines 99 to 102 in 9dac5c4
I'm seeing some discussion in a PR on actions/runner about this - there's a very familiar error log at the bottom: actions/runner#612 If I had to guess, I'd guess that the official GitHub runners have some flag set on them that is allowing them to run nested composite actions, but your self-hosted runner doesn't. I'm genuinely unsure what can be done about that, sorry. Other than filing a bug report with actions/runner, the only advice I can give you is to consider another solution. If you need to stick with cloud services, perhaps Vercel/Netlify? Or alternatively you could copy and amend the procedure from this action (https://github.com/rossjrw/pr-preview-action/blob/main/action.yml) and retrofit it directly into your workflow. I can't guarantee you won't hit the same error somewhere else, but it might help. |
Hey Ross, Good find with that link. This morning it clicked that you have some nested actions (I saw them at https://github.com/rossjrw/pr-preview-action#acknowledgements), and that I saw some stuff about I've just seen your's is marked with composite, in the last link you sent: https://github.com/rossjrw/pr-preview-action/blob/main/action.yml#L53. I will try your suggestion of fitting the steps directly into our action, to remove a layer of nesting . If that fails, I'll dig more into self-hosted runners supporting composite actions. Fantastic project btw :) |
The issue isn't with this action specifically, but seemingly with composite actions in self-hosted runners in general. |
It's working great with the .yaml and /lib/*.sh files in-lined into our repo! GitHub pages seems a bit picky with the deploy, but I'm trying some suggestions at JamesIves/github-pages-deploy-action#48. Tips for self-hosted users of this app:
|
Good to know that you've managed to get it mostly working @IdiosApps. Sorry, I'm not sure what the linked issue has to do with self-hosted runners - could you clarify? Is the section starting 'tips for self hosted users' something you recommend I add to my documentation? |
I guess the linked issue may not have anything to do with it - I hit some issues with it in this process though, so they seem relevant. In-lining everything into our repo so it isn't composite was the main advice, and it only took a few hours to iterate and get it working from there. I think the tips may save GitHub Enterprise users a little time, so adding them to the docs may be worthwhile. |
Reopening this issue as a documentation task |
In that case, I'm happy to raise a PR for it when I get some time :) |
I have googled around the error
uses: keyword is not currently supported
, but couldn't figure out how to fix this issue (other actions are working fine, and they useuses
). It's the first time I've seen this, so I thought I'd raise an issue here.I can see that the Action works nice for public repos:
https://github.com/rossjrw/pr-preview-action/tree/gh-pages/pr-preview/pr-8
#8
I'm trying this in GitHub Enterprise on a self-hosted runner, but it fails with a really weird error.
Action run logs
Workflow yaml
Indentaiton may be off due to copy paste, but here is the action - pretty much the same as an example from the readme:
If I remove
- uses: rossjrw/pr-preview-action@v1
, the logs manage to checkout and then try and install yarn etc.So, it seems like it gets confused on the very last line.
The text was updated successfully, but these errors were encountered: