Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OsStr handling to comparison #9

Open
epage opened this issue Jul 21, 2021 · 0 comments
Open

Add OsStr handling to comparison #9

epage opened this issue Jul 21, 2021 · 0 comments

Comments

@epage
Copy link
Contributor

epage commented Jul 21, 2021 •
edited
Loading

Unsure how much it ties to performance but it is tied to maturity.

Places for non-UTF-8:

  • --arg value where value is not UTF-8
  • --arg=value where value is not UTF-8
  • -avalue where value is not UTF-8

Behavior

  • String: gives proper error message
  • PathBuf / OsString: receives the value correctly

(depending on if the parser supports the case at all)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage