Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show all day events #23

Open
rosenpin opened this issue Apr 14, 2020 · 3 comments
Open

Option to show all day events #23

rosenpin opened this issue Apr 14, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@rosenpin
Copy link
Owner

Currently, we filter out all day events in the get_closest function
This is done because otherwise, the all day event will always be shown when it's taking place even if other events are more relevant

Option 1:

Make this optional using a flag

Option 2:

Show other event unless the end time of the all day event is before the start time of the closest event

I personally prefer option 2 as it will do things the 'smart' way, only show all day events if there's nothing else more interesting

@rosenpin rosenpin added the enhancement New feature or request label Apr 14, 2020
@fabfurnari
Copy link
Contributor

What about multiple all day events?

@rosenpin
Copy link
Owner Author

rosenpin commented Apr 14, 2020

agh, good question
maybe just print out "multiple all day events" or something like this, prompting the user to click it and view the full calendar
or maybe, print them comma separated, with max length of like 20 chars followed by ...
Example: Buy milk, Call mom, Check on...

@rosenpin
Copy link
Owner Author

A better way to put it would be:
If next event is tomorrow and closest all day event is today - show all day event

If more than one all day event, concat them up to N string length, order by the way Google's API provides the events

All day event 1, All day event 2, All...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants